Skip to content

Updated ServerPromptsTest, move AbstractTransport to it's own file #376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Updated ServerPromptsTest, move AbstractTransport to it's own file #376

wants to merge 1 commit into from
+203 −79

Conversation

@kpavlov
Copy link
Contributor

@kpavlov kpavlov commented Nov 7, 2025 •
edited
Loading

Refactor and enhance prompt handling logic and tests, update Kotest version and modularize AbstractTransport

  • Added more post-conditions/scenarios to ServerPromptsTest
  • Extracted AbstractTransport to a dedicated file for modularity.
  • Improved Protocol connection state validation: When disconnected, the Protocol will throw IllegalStateException instead of Error.
  • Downgraded Kotest dependency to 5.9.1 to ensure compatibility with JVM 1.8.
  • Minor Kotlin fixes and suppressions to improve code quality.

Motivation and Context

Improve test scenarios in ServerPromptsTest

How Has This Been Tested?

Integration tests updated

Breaking Changes

When disconnected, the Protocol will throw IllegalStateException instead of Error.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update
  • Test update
  • Refactoring

Checklist

  • I have read the MCP Documentation
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have added or updated documentation as needed

Additional context

@kpavlov kpavlov added tests enhancement New feature or request dependencies Pull requests that update a dependency file labels Nov 7, 2025
@kpavlov kpavlov mentioned this pull request Nov 7, 2025
Closed
10 tasks
@kpavlov
Refactor and enhance prompt handling logic, update Kotest version, an…
9ce7ee7 
…d modularize `AbstractTransport`

- Extracted `AbstractTransport` to a dedicated file for modularity.
- Improved prompt validation with `require` statement and updated related tests.
- Downgraded Kotest dependency to 5.9.1 to ensure compatibility with JVM 1.8.
- Fixed typos and improved test cases for better clarity.
- Minor Kotlin fixes and suppressions to improve code quality.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@devcrocod devcrocod Awaiting requested review from devcrocod

@tiginamaria tiginamaria Awaiting requested review from tiginamaria

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

dependencies Pull requests that update a dependency file enhancement New feature or request tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kpavlov